Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mirror throwing prematured toasts #2320

Merged

Conversation

bigint
Copy link
Member

@bigint bigint commented Apr 3, 2023

What does this PR do?

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@bigint bigint linked an issue Apr 3, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
prerender ✅ Ready (Inspect) Visit Preview Apr 3, 2023 4:43am
web ✅ Ready (Inspect) Visit Preview Apr 3, 2023 4:43am

@bigint bigint merged commit 2a5c738 into main Apr 3, 2023
@bigint bigint deleted the 2319-fix-mirror-throw-toast-even-before-mirroring-using-withsig branch April 3, 2023 04:41
@vercel vercel bot temporarily deployed to Preview – web April 3, 2023 04:42 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender April 3, 2023 04:43 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mirror throw toast even before mirroring using withSig
1 participant