Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate feeds worker to next api #4021

Merged
merged 1 commit into from
Nov 17, 2023
Merged

feat: migrate feeds worker to next api #4021

merged 1 commit into from
Nov 17, 2023

Conversation

bigint
Copy link
Member

@bigint bigint commented Nov 17, 2023

What does this PR do?

🤖[deprecated] Generated by Copilot at 687dddc

This pull request refactors and simplifies the feed provider and algorithm modules for the hey and k3l providers, and moves them from the workers package to the api package. It also replaces the deprecated feeds gateway with a new API endpoint /feed/getPublicationIds that returns publication IDs based on the feed parameters. It removes unused files, imports, parameters and constants related to the feeds gateway and the workers package.

Related issues

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

🤖[deprecated] Generated by Copilot at 687dddc

  • Add API endpoint /feed/getPublicationIds to return publication IDs based on feed parameters (link)
  • Update feed algorithm modules to use relative imports and remove unused env parameter (link, link, link, link, link, link, link)
  • Update heyFeed module to use relative imports, remove unused env parameter, and remove default case (link)
  • Rename feed provider and helper modules from packages/workers/feeds to apps/api/utils/feeds (link, link, link)
  • Delete unused files from packages/workers/feeds (link, link, link, link, link, link, link)
  • Update lib module to use new API URL and endpoint for getting publication IDs (link, link)
  • Remove unused constants and ports related to feeds gateway (link, link, link)

Emoji

🚀♻️🔥

Copy link

height bot commented Nov 17, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
api ✅ Ready (Inspect) Visit Preview Nov 17, 2023 7:12am
prerender ✅ Ready (Inspect) Visit Preview Nov 17, 2023 7:12am
web ✅ Ready (Inspect) Visit Preview Nov 17, 2023 7:12am

@bigint bigint merged commit ab81314 into main Nov 17, 2023
4 of 9 checks passed
@bigint bigint deleted the feeds-to-api branch November 17, 2023 07:07
@vercel vercel bot temporarily deployed to Preview – prerender November 17, 2023 07:08 Inactive
@vercel vercel bot temporarily deployed to Preview – api November 17, 2023 07:08 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 17, 2023 07:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant