Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't escape markdown underscores #4896

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented May 7, 2024

What does this PR do?

Don't escape underscores in the mention handles when saving the editor document as Markdown string.

I also install vitest to apps/web so that I can test it.

Related issues

Fixes #4895

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explanation of the changes

Before

Screenshot 2024-05-07 at 19 41 48

After

Screenshot 2024-05-07 at 19 41 03

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web ❌ Failed (Inspect) May 7, 2024 5:09pm

Copy link

vercel bot commented May 7, 2024

@ocavue is attempting to deploy a commit to the Hey Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – web May 7, 2024 09:40 Inactive
@ocavue ocavue marked this pull request as ready for review May 7, 2024 09:44
@ocavue ocavue requested a review from bigint as a code owner May 7, 2024 09:44
@vercel vercel bot temporarily deployed to Preview – web May 7, 2024 09:47 Inactive
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

LGTM

@bigint bigint merged commit 83846fa into heyxyz:main May 7, 2024
1 of 6 checks passed
@vercel vercel bot temporarily deployed to Preview – web May 7, 2024 17:09 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Handles with _ not rendering
2 participants