Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logout routing issue from other pages #982

Merged
merged 8 commits into from
Oct 31, 2022
Merged

fix: logout routing issue from other pages #982

merged 8 commits into from
Oct 31, 2022

Conversation

bhavya2611
Copy link
Contributor

What does this PR do?

Fixes Routing issue after logout from the messages page

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Logout from the home page and see if it redirects to the home page

@vercel
Copy link

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 6:58PM (UTC)

@bhavya2611 bhavya2611 self-assigned this Oct 28, 2022
@vercel vercel bot temporarily deployed to Preview October 28, 2022 09:01 Inactive
@vercel vercel bot temporarily deployed to Preview October 28, 2022 09:10 Inactive
@vercel vercel bot temporarily deployed to Preview October 28, 2022 09:14 Inactive
@vercel vercel bot temporarily deployed to Preview October 28, 2022 12:22 Inactive
@vercel vercel bot temporarily deployed to Preview October 28, 2022 12:25 Inactive
@bigint bigint changed the title fix logout routing issue from other pages fix: logout routing issue from other pages Oct 28, 2022
Copy link
Contributor

@elisealix22 elisealix22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to explicitly check if currentProfile is around to 404 as noted lol, but this works!

src/components/Messages/Message.tsx Outdated Show resolved Hide resolved
src/components/Messages/PreviewList.tsx Outdated Show resolved Hide resolved
src/components/Messages/index.tsx Outdated Show resolved Hide resolved
…/bugs

Conflicts:
src/components/Shared/Navbar/Search.tsx
src/components/Shared/Navbar/SignedUser.tsx
@vercel vercel bot temporarily deployed to Preview October 31, 2022 17:50 Inactive
@vercel vercel bot temporarily deployed to Preview October 31, 2022 18:15 Inactive
@vercel vercel bot temporarily deployed to Preview October 31, 2022 18:58 Inactive
@bhavya2611 bhavya2611 merged commit 18b114b into main Oct 31, 2022
@bhavya2611 bhavya2611 deleted the fix/bugs branch October 31, 2022 19:11
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 31, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Lenster Contributor:

GitPOAP: 2022 Lenster Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants