Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emojis with speech bubbles to face correct direction #92

Merged
merged 4 commits into from
Dec 20, 2019

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Dec 2, 2019

#72

image

Not failing due to my changes

@b-g
Copy link
Member

b-g commented Dec 2, 2019

@carlinmack Will wait with all merges until we have the tests fixed. Sorry!

@carlinmack
Copy link
Contributor Author

One obvious problem with these right now is the lack of consistency in the way that the stem connects to the bubble. I think the spiky one has the most openmoji-consistent style but I didn't want to change the others without some discussion

@b-g
Copy link
Member

b-g commented Dec 4, 2019

@carlinmack

Many thanks for this! Yes good that the directions are now aligned to other vendors, also I find it more consistent/better how you re-designed the way stem and bubble are connected. Nice!

Just I don't think it is a good idea to introduce a half circle for 1F4AC. As we try hard to stay with minimal shapes and always aim to reduce complexity. Also it would be more consistent with the other bubbles.

OK?

2019-12-04 at 13 55

(Also there is a merged conflict on the changelog now)

@carlinmack
Copy link
Contributor Author

@b-g merging as I've changed from a semi circle to a full circle

@carlinmack carlinmack merged commit a938b2b into hfg-gmuend:master Dec 20, 2019
@carlinmack carlinmack deleted the bubbles branch January 6, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants