Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feet #94

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Improve feet #94

merged 1 commit into from
Dec 4, 2019

Conversation

carlinmack
Copy link
Contributor

#72

@dnlutz thoughts? before isn't even recognisably feet

@dnlutz
Copy link
Contributor

dnlutz commented Dec 3, 2019

hello @carlinmack which foot are you refering to?
sorry, but github ist sometimes still a bit confusing for me ; )

i would suggest to use a more geometric foot then it fits better to the other openmoji.
geometric_foot

@carlinmack
Copy link
Contributor Author

carlinmack commented Dec 3, 2019

If you click on "Files Changed" at the top and click this button, you'll see my changes

image

@b-g
Copy link
Member

b-g commented Dec 4, 2019

Thanks! This PR seems redundant with 4920b03. Not merged and closed. Hope this is fine for everyone.

@b-g b-g closed this Dec 4, 2019
@carlinmack
Copy link
Contributor Author

Can we please review what commits do before closing them? This commit deals with 1F463 not 1F9B6

Please re-review this, thanks

@b-g b-g reopened this Dec 4, 2019
@b-g b-g merged commit 5361b19 into hfg-gmuend:master Dec 4, 2019
@b-g
Copy link
Member

b-g commented Dec 4, 2019

Hi @carlinmack, I'm really sorry! ❤️ I crossed wires and thought I've had already reviewed it. My apologies! Yes ... it is a nice improved! Merged! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants