fix: wsrun doesn't mimick yarn workspace resolution #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spion-h4
reviewed
Sep 30, 2019
| const registryFilenames = ['package.json', 'yarn.json'] | ||
| const registryFolders = ['node_modules'] | ||
| const trailingPattern = `/+(${registryFilenames.join('|')})` | ||
| const ignorePatterns = registryFolders.map(folder => `/${folder}/**/+(${registryFilenames.join('|')})`) |
There was a problem hiding this comment.
This does mimic yarn exactly, but there is a bug because it will also match files named package_json or packageTjson or any other letter due to the dot. Which... not a big deal, but might be useful to add a comment about this.
edit: never mind, its not regex
spion-h4
approved these changes
Sep 30, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69