-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch SIGTERM signal to gracefully terminate #2
Comments
I tried to manage this, but without success. Seams like Socket.IO is a bit nasty when an immediate shutdown is desired. If you want, you can try with branch https://github.com/hgoebl/nerdshow/tree/0.5.0-sigterm-and-upgrade-dep and create PR then. Don't have enough time currently. |
Tested it and works OK, thank you.
PR sent as instructed. |
upgrade dependencies, listen on SIGTERM (fixes #2)
Thanks for contributing @pataquets |
While dockerizing the app, I've found that it ignores
SIGTERM
signals from bothCTRL+C
anddocker stop
commands (it just gets killed after 10 seconds in the later case).Trapping
SIGTERM
signal to terminate gracefully would prevent this annoyance.Thank you for this useful app.
The text was updated successfully, but these errors were encountered: