-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround pintpandas iter issue #1125
Conversation
Super nice @andrewgsavage ! |
awesome |
There are a few failing tests. |
One thing I noticed, we'll need a hack to workaround e.g. |
OK sounds like you're happy with this approach, will try to get this working. |
I have to say that I was surprised that it worked. A few years ago I tried doing this with the
Not required any more, done in #1127 |
I was trying to fix the pending issues without success. Likely because Magic methods like iter are looked up on the class, not the instance as described here. I will release pint-pandas and then maybe we should rediscuss if we create a Quantity class that inherits from numpy array. |
black -t py36 . && isort -rc . && flake8
with no errorsPossible work around for the iter issue
Drops the failing tests from
====== 21 failed, 329 passed, 29 xfailed, 2 xpassed, 6 warnings in 21.44s ======
to
====== 4 failed, 346 passed, 28 xfailed, 3 xpassed, 11 warnings in 17.55s ======
hgrecco/pint-pandas#33
see also
#753