Add support for Quantity as value in the constructor #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jules-ch
force-pushed
the
quantity-with-quantity
branch
from
2a0d917
to
a0033ef
Compare
Simplify constructor - Handle special cases at first to fail fast - Flatten nested conditions - Handle units first - Convert magnitude if value is Quantity Closes hgrecco#1231
jules-ch
force-pushed
the
quantity-with-quantity
branch
from
a0033ef
to
0cbfef6
Compare
|
Thanks for th PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify constructor
Handle special cases at first to fail fast
Flatten nested conditions
Handle units first
Convert magnitude if value is Quantity
Closes Creating Quantity with Quantity #1231
Executed
pre-commit run --all-fileswith no errorsThe change is fully covered by automated unit tests
Documented in docs/ as appropriate
Added an entry to the CHANGES file