Update hour symbol to h
#1454
Merged
Update hour symbol to h
#1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace h symbol for planck constant to `ℎ` - Add breaking change in CHANGES
|
@hgrecco tell me if that's ok with you. |
|
@hgrecco , can I have your green light for this change. So we can integrate this in the new release ? |
|
I agree with this change. But I think with this change! |
|
@hgrecco what was the but ? |
|
Sorry, I was very tired that day :-D I was saying that it should be documented as breaking change and then I noticed that was the case! |
|
Alright I'm gonna merge this then. |
jules-ch
force-pushed
the
fix-719-hour-alias
branch
from
234d34d
to
c71b836
Compare
3 tasks
jpeloquin
added a commit
to jpeloquin/prunetest
that referenced
this pull request
Feb 16, 2023
Can't define an alias twice, so now that "h" means hours by default (as of 2022-03-03; hgrecco/pint#1454) our (re)definition of "h" raises an exception and we need to get rid of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace h symbol for planck constant to
ℎAdd breaking change in CHANGES
Closes "h" should be the abbreviation of hours #719
Executed
pre-commit run --all-fileswith no errorsThe change is fully covered by automated unit tests
Documented in docs/ as appropriate
Added an entry to the CHANGES file