Bakels: extend to add support for .co.uk domain. #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknndy
approved these changes
Jul 6, 2024
|
Thank you @jknndy! |
jayaddison
added a commit
that referenced
this pull request
Jul 11, 2024
This reverts commit 0094694.
jayaddison
added a commit
that referenced
this pull request
Jul 11, 2024
This reverts commit e8a0dac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These recipes looked well-structured and useful to me while reviewing #1096 so I wanted to extend their support to their
.co.ukdomain.Doing that seems to have uncovered a couple of other issues:
hostfield might not be easily testable for non-default domains?instructionshandling logic.Resolves #1099.
cc @heathrampazis