This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
Typecheck with enable_strict_string_concat_interp #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies are not yet ready, so CI will fail.
lexidor
commented
Apr 27, 2021
| // Indexing them with $actual->$int_one` is very weird, but okay. | ||
| // Indexing them with float, bool something that coerces, is a bug in your test. | ||
| // Let's fail loudly instead of silently depending on implicit casts. | ||
| invariant( |
There was a problem hiding this comment.
This change is a BC break.
->.$key was failing, since $key was not arraykey.
Instead of casting, I decided to fail loudly if a non-arraykey comes along.
Accessing properties with floats /works/ at runtime, but this must be a bug on the callers end.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies are not yet ready, so CI will fail.