Suppress lint error according to error code level markers #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Atry
force-pushed
the
suppress-error-code
branch
from
3f17220
to
79c1e39
Compare
Atry
force-pushed
the
suppress-error-code
branch
3 times, most recently
from
602c81d
to
8cfaa1e
Compare
fredemmott
approved these changes
Nov 10, 2021
| "blame": null, | ||
| "blame_pretty": null, | ||
| "blame": "cannot_be_null is null", | ||
| "blame_pretty": "cannot_be_null is null", | ||
| "description": "Invalid null check: This expression will always return `false`.\nA value of type `int` can never be null." | ||
| } | ||
| ] |
There was a problem hiding this comment.
(separate PR) It's probably worth adding range information to LinterTestTrait::getErrorAsShape() so that these tests also make sure the the information provided to IDEs is accurate. This will require updating many of the existing tests.
…urce file for all lint markers
… of File::lintMarkers
…ter and HHClientLinter
Atry
force-pushed
the
suppress-error-code
branch
from
8cfaa1e
to
9844087
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.