Suppress lint errors file by file #418
Conversation
Atry
force-pushed
the
suppress-5639-per-file
branch
from
b881ce8
to
56f4c38
Compare
Atry
changed the title
Atry
force-pushed
the
suppress-5639-per-file
branch
from
56f4c38
to
1acb8ca
Compare
| */ | ||
| namespace Facebook\HHAST; | ||
| use namespace Facebook\TypeAssert; | ||
| use namespace HH\Lib\Dict; | ||
| /* HHAST_IGNORE_ALL[5607] 5607 is ignored because of false positives when comparing a generic to a typed value */ | ||
| /* HHAST_IGNORE_ALL[5624] HHAST_IGNORE_ALL[5639] 5624 and 5639 are ignored because they insist on using co(tra)variant generics. Could this break external consumers? */ |
There was a problem hiding this comment.
This linter (edit: 5639) might also be good for the default blacklist - there's an ongoing discussion about removing it entirely at https://fb.workplace.com/groups/hackforhiphop/posts/7429940763721141
In short: It's accurate, but it's highly opinionated, and there's not consensus on the behavior it encourages being a good thing.
This isn't the same as the other codes we'd want to always-ignore, but "pretend it doesn't exist" may be the right thing to do for "may be deleted soon". Perhaps making it off-by-default but explicitly-includable may be better.
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
... for the whole file changes, not specifically the bracket :)
There was a problem hiding this comment.
Seems like I did something wrong when resolving conflicts
This is not a real problem, just because the diff tool does not match the structural changes unfortunately.
No description provided.