Attempt to fix the composer install #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer isn't happy with installing HackTest, since that requires the HSL, which requires HackTest. There must be some way of aliasing this that Fred referred to, but it appears it was already doing that. Maybe we weren't specific enough? #121 (comment) > Still failing; I think this is the compsoer.json branch configuration - for example, we have this in master: > > ``` > "extra": { > "branch-alias": { > "dev-master": "4.x-dev" > } > }, > ```
fredemmott
reviewed
Feb 10, 2020
| @@ -3,7 +3,7 @@ | |||
| "description": "The Hack Standard Library", | |||
| "extra": { | |||
| "branch-alias": { | |||
| "dev-master": "3.x-dev" | |||
There was a problem hiding this comment.
you probably also want "dev-v3.30.x": "3.30.x-dev" in here
It needs to understand that this is the HSL HackTest is looking for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer isn't happy with installing HackTest, since that requires the HSL, which requires HackTest.
There must be some way of aliasing this that Fred referred to, but it appears it was already doing that.
Maybe we weren't specific enough?
#121 (comment)