Skip to content

Commit 20b292e

Browse files
committed
fixes for HHVM 4.29+
1 parent 353ead3 commit 20b292e

File tree

4 files changed

+23
-24
lines changed

4 files changed

+23
-24
lines changed

composer.lock

Lines changed: 18 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/build/AbstractMarkdownRenderBuildStep.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ private function parseSingleRenderResult(string $line): ?string {
5757
return null;
5858
}
5959
Log::v('-');
60-
list($_in, $out) = \explode(' -> ', $line);
61-
// $in still has 'OK] ' prefix, but we don't need it now anyway
62-
return $out;
60+
$parts = \explode(' -> ', $line);
61+
// $parts[0] still has 'OK] ' prefix, but we don't need it now anyway
62+
return $parts[1];
6363
}
6464

6565
public static function getOutputFileName(string $input): string {

src/site/controllers/HTTP404Controller.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ protected function getNotFoundMessage(): XHPRoot {
118118
$parts = explode('/', $path);
119119

120120
if (count($parts) === 2) {
121-
list($_, $id) = $parts;
121+
$id = $parts[1];
122122
$url = $this->getSuggestedUrl($id);
123123
if ($url !== null) {
124124
return (

src/site/controllers/WebController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function __construct(
3636
ImmMap<string, string> $parameters,
3737
private ServerRequestInterface $request,
3838
) {
39-
$combined_params = $parameters->toMap();
39+
$combined_params = new Map($parameters);
4040
foreach ($request->getQueryParams() as $key => $value) {
4141
if (is_array($value)) {
4242
continue;

0 commit comments

Comments
 (0)