Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ 功能建议 ] 增加Oracle数据库的支持 #144

Closed
hhyo opened this issue Apr 22, 2019 · 22 comments
Closed

[ 功能建议 ] 增加Oracle数据库的支持 #144

hhyo opened this issue Apr 22, 2019 · 22 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@hhyo
Copy link
Owner

hhyo commented Apr 22, 2019

由于没有接触过Oracle,不方便测试,所以一直没有加入Oracle模块,希望有相关需求的用户可以认领该功能,实现对Oracle的支持,使用Engine接入非常简单,可以在该Issue下讨论

希望如何解决/实现它

使用Engine接入Oracle的上线、查询功能,可以参考#91 #101

其他信息

https://github.com/hhyo/Archery/tree/master/sql/engines

@hhyo hhyo added enhancement New feature or request help wanted Extra attention is needed labels Apr 22, 2019
@LeoQuote
Copy link
Collaborator

立个文档的flag🤔,这周做完

@hhyo
Copy link
Owner Author

hhyo commented Apr 23, 2019

🏃

@yzypals
Copy link
Collaborator

yzypals commented Apr 25, 2019

拭目以待啊 , 找了一大圈 没找到支持oracle的开源项目

@LeoQuote
Copy link
Collaborator

@yzypals 由于缺乏oracle的资源, 目前的计划是出engine的文档, 然后其他人可以根据文档开发oracle相关功能。

@yzypals
Copy link
Collaborator

yzypals commented Apr 26, 2019

@LeoQuote 文档有吗 完全看源代码 有点累。 目前 想上线这个 项目 测试用 , 需要 上oracle的 功能, 前期 就上线 审核 记录3个功能就行, 自己慢慢改代码。 现在在读源代码 整理你们 思路, 如果有开发文档 就更好了。

@LeoQuote
Copy link
Collaborator

@LeoQuote
Copy link
Collaborator

LeoQuote commented May 7, 2019

@yzypals 我们已经有一个oracle的初稿了, 在上面提到的pr中有代码

@hhyo
Copy link
Owner Author

hhyo commented May 9, 2019

@yzypals 查询已经合并进主干分支,前面的执行功能可以在该基础上提交PR,感谢

@yzypals
Copy link
Collaborator

yzypals commented May 10, 2019

@hhyo 我来同步下信息, oracle 查询功能你们测试了吗

@yzypals
Copy link
Collaborator

yzypals commented May 10, 2019

oracle ajax 传的是db_name ,后端接收的是schema_name

@hhyo
Copy link
Owner Author

hhyo commented May 10, 2019

@hhyo 我来同步下信息, oracle 查询功能你们测试了吗

目前还没有进行过测试👣

@hhyo
Copy link
Owner Author

hhyo commented May 12, 2019

#196

LeoQuote added a commit that referenced this issue May 21, 2019
@rhkjyn
Copy link

rhkjyn commented May 21, 2019

什么时候能把这个功能发上来,我们这有环境,可以安排时间测试。

@LeoQuote
Copy link
Collaborator

@rhkjyn 感谢关心,目前oracle的相关代码已合并进master,只是没有release。

目前完成工单执行和检测功能,可以进行集成测试。

@LeoQuote
Copy link
Collaborator

@rhkjyn 欢迎帮我们测试master分支并提交bug报告👏

@rhkjyn
Copy link

rhkjyn commented May 22, 2019

sql查询时提示ORA-00942: table or view does not exist,无法获取到表信息

@rhkjyn
Copy link

rhkjyn commented May 22, 2019

ORA-00942: table or view does not exist

WX20190522-160634
日志报错 select username from sys.dba_users;
理论上来说,应该不需要取sys下面的表的权限的。

@yzypals
Copy link
Collaborator

yzypals commented May 22, 2019

这个是权限的问题, 但是写这个的时候 默认拿了 oracle的系统级别的 只读权限的账号 , 这个后期 有优化的 空间

@yzypals
Copy link
Collaborator

yzypals commented May 22, 2019

找DBA 要权限 select
TABLE_NAME
from dba_tab_privs
where grantee in ('{db_name}')
union
select
OBJECT_NAME
from dba_objects
WHERE OWNER IN ('{db_name}') and object_type in ('TABLE')

@rhkjyn
Copy link

rhkjyn commented May 22, 2019

嗯,感谢您的回复,我只是觉得不应该需要去查询sys下的表

@LeoQuote
Copy link
Collaborator

@rhkjyn 非常感谢你提供的测试反馈, 如果后期还有类似问题建议新开issue比较好, 这样比较清晰.

@hhyo
Copy link
Owner Author

hhyo commented May 22, 2019

后续讨论新开issue,1.6.0已发布,此issue关闭

@hhyo hhyo closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants