Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

为ajax请求的返回错误进行分类报错 (hhyo#1346) #1365

Merged
merged 3 commits into from
Jan 28, 2022

Conversation

weideguo
Copy link
Collaborator

No description provided.

@request-info
Copy link

request-info bot commented Jan 27, 2022

你好!感谢你反馈的问题/bug,但是你的描述好像是空的,我们需要你完整的信息,这样才能帮你解决问题 如果不知道怎么写,在新建issue的时候有若干个模板可供选择,祝好!

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1365 (8263386) into master (7d8e955) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1365   +/-   ##
=======================================
  Coverage   75.39%   75.39%           
=======================================
  Files          81       81           
  Lines       12616    12616           
=======================================
  Hits         9512     9512           
  Misses       3104     3104           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8e955...8263386. Read the comment docs.

@@ -1,4 +1,4 @@
{% extends "base.html" %}
a{% extends "base.html" %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多了个A

if (status === 403) {
alert("权限错误,您没有权限查看该数据!");
} else {
alert("未知错误,数据加载失败!请检查接口返回信息和错误日志!");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

提示应该可以引导用户联系管理员了,对于提示和页面暴露错误堆栈的我后续统一处理下,alert看有没有更友好的提示组件可以替换下,感谢贡献~

@hhyo hhyo merged commit 0abcd43 into hhyo:master Jan 28, 2022
weideguo added a commit to weideguo/Archery that referenced this pull request Jan 28, 2022
* 为ajax请求的返回错误进行分类报错 (hhyo#1346)

* 小优化
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants