Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复实例check返回连接状态错误bug fix #1179 #1407

Merged
merged 4 commits into from
Mar 27, 2022

Conversation

nick2wang
Copy link
Collaborator

fix #1179
redis和clickhouse engine使用的连接器在实例信息配置错误的情况下不会抛出异常,导致实例配置无论正确与否都会返回连接成功

修复实例测试连接状态错误bug
更新测试用例
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #1407 (0f0c981) into master (bbcf17a) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   74.94%   74.94%           
=======================================
  Files          82       82           
  Lines       13205    13209    +4     
=======================================
+ Hits         9896     9899    +3     
- Misses       3309     3310    +1     
Impacted Files Coverage Δ
sql/engines/redis.py 76.41% <0.00%> (-0.73%) ⬇️
common/check.py 83.80% <100.00%> (+0.47%) ⬆️
common/tests.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbcf17a...0f0c981. Read the comment docs.

Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhyo hhyo merged commit 27bdb3d into hhyo:master Mar 27, 2022
@nick2wang nick2wang deleted the fix-instance-check-bug branch March 28, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ bug ]redis测试连接时,无法校验密码是否正确
3 participants