Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qcluster 启动方式改为supervisor启动, 增加稳定性 #230

Merged
merged 1 commit into from
May 28, 2019

Conversation

LeoQuote
Copy link
Collaborator

@LeoQuote LeoQuote commented May 28, 2019

关联issue
#242
#224
#188
#211
#218

@LeoQuote LeoQuote requested a review from hhyo May 28, 2019 10:09
@LeoQuote LeoQuote added area/docker area/qcluster bug Something isn't working labels May 28, 2019
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files          64       64           
  Lines        7964     7964           
=======================================
  Hits         6544     6544           
  Misses       1420     1420

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09dd4e...521d5d6. Read the comment docs.

Copy link
Owner

@hhyo hhyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug.sh文件也改下?

@LeoQuote
Copy link
Collaborator Author

LeoQuote commented May 28, 2019 via email

@hhyo hhyo merged commit afa9831 into master May 28, 2019
@hhyo
Copy link
Owner

hhyo commented Jun 1, 2019

通过docker-compose 启动,无法控制启动顺序,有可能Archery服务启动qcluster时redis还没有启动,会导致qcluster启动失败,但是qcluster不会去重试Koed00/django-q#223
进程也不退出,就会有个假的进程在

[2019-06-01 09:37:42,726][MainThread:4656580032][task_id:django-q][cluster.py:53][INFO]- Q Cluster-18154 starting.
[2019-06-01 09:37:42,751][MainThread:4656580032][task_id:django-q][redis_broker.py:37][ERROR]- Can not connect to Redis server.

supervisor也只是解决了重启的问提,初次启动这个坑还在

@LeoQuote
Copy link
Collaborator Author

LeoQuote commented Jun 1, 2019

可以考虑使用docker -compose的功能
depends_on:
- db

@hhyo hhyo deleted the bugfix/stable-qcluster branch July 6, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker area/qcluster bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants