Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

升级bootstrap-table版本(由v1.18.3->v1.22.4) #2686

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

feiazifeiazi
Copy link
Contributor

@feiazifeiazi feiazifeiazi commented Jun 20, 2024

  1. 升级 bootstrap-table版本。
    由bootstrap-table-v1.18.3 升级到bootstrap-table-v1.22.4。
  2. 升级后解决导出为excel的时间问题。
  3. 旧版本先保留。方便验证问题。
  4. 目前没啥大问题。 小问题1:redis执行 info keyspace时, 显示了[object,object]问题。
  5. 之前发现升级bootstrap-table后,SQL查询在输入有点点小问题 (修改ext-language_tools.js解决的)。但现在重现不了。

之前的PR:#2622

@feiazifeiazi feiazifeiazi changed the title 升级 bootstrap-table版本 升级bootstrap-table版本(由bootstrap-table-v1.18.3->bootstrap-table-v1.22.4) Jun 20, 2024
@feiazifeiazi feiazifeiazi changed the title 升级bootstrap-table版本(由bootstrap-table-v1.18.3->bootstrap-table-v1.22.4) 升级bootstrap-table版本(由v1.18.3->v1.22.4) Jun 20, 2024
@LeoQuote
Copy link
Collaborator

首先是旧版本不要保留,没有用到的文件必然是要清理的,如果有问题可以直接整体回退

你提到的bug,特别是redis查询显示问题的bug,需要解决下。

@feiazifeiazi
Copy link
Contributor Author

feiazifeiazi commented Jun 20, 2024

首先是旧版本不要保留,没有用到的文件必然是要清理的,如果有问题可以直接整体回退

你提到的bug,特别是redis查询显示问题的bug,需要解决下。

恩。我删一下旧文件。
我先提交这个pr, redis问题我再修复。那个命令默认情况是执行不了,没有在默认的支持命令里面,不太影响。
CI怎么总是报错,我只是提交了JS而已。
import pandas as pd
File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pandas/init.py", line 22, in
from pandas.compat import is_numpy_dev as _is_numpy_dev # pyright: ignore # noqa:F401
File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pandas/compat/init.py", line 18, in
from pandas.compat.numpy import (
File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pandas/compat/numpy/init.py", line 4, in
from pandas.util.version import Version
File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pandas/util/init.py", line 2, in
from pandas.util._decorators import ( # noqa:F401
File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pandas/util/_decorators.py", line 14, in
from pandas._libs.properties import cache_readonly
File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/pandas/_libs/init.py", line 13, in
from pandas._libs.interval import Interval
File "pandas/_libs/interval.pyx", line 1, in init pandas._libs.interval
ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
Error: Process completed with exit code 1.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.13%. Comparing base (7ca0793) to head (1b41f36).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2686   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files         117      117           
  Lines       16169    16169           
=======================================
  Hits        12472    12472           
  Misses       3697     3697           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feiazifeiazi
Copy link
Contributor Author

首先是旧版本不要保留,没有用到的文件必然是要清理的,如果有问题可以直接整体回退

你提到的bug,特别是redis查询显示问题的bug,需要解决下。

Redis的显示问题,已另外提交PR。

@LeoQuote LeoQuote merged commit 24f86de into hhyo:master Jun 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants