Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

使用新版pyecharts实现数据可视化 #422

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Aug 31, 2019

新版pyecharts整体进行了重构,为方便后续拓展更多可视化分析,希望可以用新版pyecharts重写目前的dashboard

这是一个flag,希望有兴趣的小伙伴可以提交PR,可在此交流

https://github.com/pyecharts/pyecharts

@LeoQuote
Copy link
Collaborator

https://bokeh.org/ 这个也很酷,要是重构难度和重写一样,可能这个也可以考虑

@hhyo
Copy link
Owner Author

hhyo commented Sep 1, 2019

目前图不多也都是简单的图,难度不大,不过bokeh相比pyecharts更合适么?

@LeoQuote
Copy link
Collaborator

LeoQuote commented Sep 1, 2019

其实也没啥更合适,就是这个demo就看起来很酷炫,和pyechart比起来似乎要牛逼一点😂

@LeoQuote LeoQuote added enhancement New feature or request area/frontend labels Sep 2, 2019
@yuandajn578
Copy link
Contributor

一个flag,希望有兴趣的小伙伴可以提交PR,可在此交流

@hhyo @LeoQuote
这是我们之前用过的一个同类型的审核平台,前端做的很炫,不妨参考下:
https://yearning.io/

@LeoQuote
Copy link
Collaborator

LeoQuote commented Sep 6, 2019

感谢,yearning 前端确实是很优秀,不过是vue写的前端,确实写起来要简单一些。现在项目主要还是 bootstrap + django template ,可能借鉴意义没有那么大

@hhyo
Copy link
Owner Author

hhyo commented Sep 6, 2019

这个和前端框架选型有关,目前Archery前端不会有风格上的调整,以功能完善和体验优化为主,但不排除后期会重构

@hhyo
Copy link
Owner Author

hhyo commented Sep 8, 2019

基本完成,就是切换到图表菜单栏会出现一小部分的空白

@codecov
Copy link

codecov bot commented Sep 8, 2019

Codecov Report

Merging #422 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   84.93%   84.93%   +<.01%     
==========================================
  Files          70       70              
  Lines        9121     9123       +2     
==========================================
+ Hits         7747     7749       +2     
  Misses       1374     1374
Impacted Files Coverage Δ
common/utils/chart_dao.py 100% <100%> (ø) ⬆️
common/dashboard.py 97.36% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80cb4c1...9142b09. Read the comment docs.

@hhyo hhyo marked this pull request as ready for review September 8, 2019 10:52
@hhyo hhyo requested a review from LeoQuote September 8, 2019 10:54
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhyo hhyo merged commit eaf550d into master Sep 9, 2019
@hhyo hhyo deleted the feature/upgrade-pyecharts branch September 9, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants