Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL执行权限区分资源组粒度和提交人粒度,便于提交人自助上线工单 #74

Merged
merged 8 commits into from
Mar 24, 2019

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Mar 21, 2019

#70

SQL执行权限拆分为

  1. sql_execute_for_resource_group 执行SQL上线工单(资源组粒度)
  2. sql_execute 执行SQL上线工单(仅自己提交的)

拥有资源组粒度权限sql_execute_for_resource_group的用户,可以查看并且执行整个资源组审核通过待执行的工单,包括立即执行和定时执行
拥有个人粒度权限sql_execute的用户,仅可以执行自己提交并被审核通过的工单,包括立即执行和定时执行

PS:目前的执行权限是资源组粒度的,具体可参考文档 工作流

@hhyo hhyo self-assigned this Mar 21, 2019
@hhyo hhyo closed this Mar 23, 2019
@hhyo hhyo reopened this Mar 24, 2019
@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #74 into master will increase coverage by 5.61%.
The diff coverage is 91.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   58.62%   64.24%   +5.61%     
==========================================
  Files          60       58       -2     
  Lines        5651     5661      +10     
==========================================
+ Hits         3313     3637     +324     
+ Misses       2338     2024     -314
Impacted Files Coverage Δ
sql/utils/tests.py 100% <100%> (ø) ⬆️
sql/sql_analyze.py 94.87% <100%> (+0.13%) ⬆️
sql/urls.py 100% <100%> (ø) ⬆️
sql/plugins/plugin.py 90.62% <100%> (-0.29%) ⬇️
sql/plugins/schemasync.py 100% <100%> (ø) ⬆️
sql/sql_optimize.py 85.96% <100%> (+0.25%) ⬆️
sql/admin.py 100% <100%> (ø) ⬆️
sql/instance.py 26.9% <100%> (+0.42%) ⬆️
sql/plugins/tests.py 100% <100%> (ø) ⬆️
sql/plugins/binglog2sql.py 100% <100%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc21fcb...5a15530. Read the comment docs.

@hhyo hhyo marked this pull request as ready for review March 24, 2019 07:27
@hhyo hhyo merged commit ea8adf7 into master Mar 24, 2019
@hhyo hhyo deleted the self_execute branch March 24, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant