Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tiny-transition): implement transition as "lagged boolean state" #93

Merged
merged 33 commits into from
Oct 25, 2023
Merged

refactor(tiny-transition): implement transition as "lagged boolean state" #93

merged 33 commits into from
Oct 25, 2023

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Oct 23, 2023 •
edited
Loading

Inspired by

this approach seems like a generalized/simplified implementation of "transition manager" core.

todo

  • show=true appear=false broken in solidjs? e9c8afd
    • it seems it's tricky to play on class/style/ref to do something effectful...

@hi-ogawa hi-ogawa mentioned this pull request Oct 23, 2023
Closed
2 tasks
@hi-ogawa hi-ogawa marked this pull request as ready for review October 23, 2023 12:41
@hi-ogawa hi-ogawa mentioned this pull request Oct 24, 2023
Closed
@hi-ogawa
Copy link
Owner Author

It looks like this approach is completely compatible with old implementation, so let's go on to remove old stuff.

@hi-ogawa hi-ogawa changed the title refactor(tiny-transition): "lagged state" interpretion of transition refactor(tiny-transition): implement transition as "lagged boolean state" Oct 25, 2023
@hi-ogawa hi-ogawa merged commit 1170950 into main Oct 25, 2023
1 check passed
@hi-ogawa hi-ogawa deleted the refactor-tiny-transition-lagged-state branch October 25, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hi-ogawa