Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use async transition for client navigation #356

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Jun 6, 2024

I thought this might simplify a lot, but it looks like interrupt-ability is different when tested on http://localhost:5173/test/transition
Maybe I'm supposed to abort fetch properly on subsequent navigation.


Also, action redirection is now broken with the message:

async/await is not yet supported in Client Components, only Server Components. This error is often caused by accidentally adding `'use client'` to a module that was originally written for the server.

@hi-ogawa
Copy link
Owner Author

hi-ogawa commented Jun 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on Graphite Graphite

Base automatically changed from refactor-rename to main June 6, 2024 05:52
@hi-ogawa hi-ogawa force-pushed the refactor-async-transition-for-client-navigation branch from 2927068 to bcf2653 Compare June 6, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant