Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rethrow action error on client #531

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Jul 9, 2024

todo

  • add test
    • client try/catch
    • closest error boundary
      • how to handle nojs action SSR? Currently error is completely silenced and it simply re-render SSR.
  • we should actually skip flight render for all errors?
    • we cannot do this if we want nojs action SSR.

Copy link
Owner Author

hi-ogawa commented Jul 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on Graphite Graphite

@hi-ogawa hi-ogawa force-pushed the fix-rethrow-action-error-2 branch from a3688bb to ec15e6b Compare July 9, 2024 10:20
@hi-ogawa hi-ogawa mentioned this pull request Jul 9, 2024
6 tasks
@hi-ogawa hi-ogawa changed the title fix: rethrow action error on client (2) fix: rethrow action error on client Jul 9, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review July 9, 2024 22:54
Copy link
Owner Author

hi-ogawa commented Jul 9, 2024

Merge activity

  • Jul 9, 7:36 PM EDT: @hi-ogawa started a stack merge that includes this pull request via Graphite.
  • Jul 9, 7:37 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 9, 7:38 PM EDT: @hi-ogawa merged this pull request with Graphite.

Base automatically changed from refactor-action-redirect-js to main July 9, 2024 23:36
@hi-ogawa hi-ogawa force-pushed the fix-rethrow-action-error-2 branch from dc5b7a8 to 8177392 Compare July 9, 2024 23:36
@hi-ogawa hi-ogawa merged commit d8887e4 into main Jul 9, 2024
6 checks passed
@hi-ogawa hi-ogawa deleted the fix-rethrow-action-error-2 branch July 9, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve server action error propagation
1 participant