HHH-16813 don't add @generated annotations if it's going to cause a compilation failure

Author: gavinking

tooling/metamodel-generator/src/main/java/org/hibernate/jpamodelgen/ClassWriter.java

@@ -98,17 +98,17 @@ private static StringBuffer generateBody(Metamodel entity, Context context) {
 		StringWriter sw = new StringWriter();
 		try ( PrintWriter pw = new PrintWriter(sw) ) {
 
+			if ( entity.getElement() instanceof TypeElement ) {
+				pw.println(writeStaticMetaModelAnnotation(entity));
+			}
+
 			if (context.addGeneratedAnnotation()) {
 				pw.println(writeGeneratedAnnotation(entity, context));
 			}
 			if (context.isAddSuppressWarningsAnnotation()) {
 				pw.println(writeSuppressWarnings());
 			}
 
-			if ( entity.getElement() instanceof TypeElement ) {
-				pw.println(writeStaticMetaModelAnnotation(entity));
-			}
-
 			printClassDeclaration(entity, pw, context);
 
 			pw.println();
@@ -203,18 +203,26 @@ private static String getFullyQualifiedClassName(Metamodel entity, String metaMo
 
 	private static String writeGeneratedAnnotation(Metamodel entity, Context context) {
 		StringBuilder generatedAnnotation = new StringBuilder();
-		generatedAnnotation.append( "@" )
+		generatedAnnotation
+				.append( "@" )
 				.append( entity.importType( "jakarta.annotation.Generated" ) )
-				.append( "(value = \"" )
-				.append( JPAMetaModelEntityProcessor.class.getName() );
+				.append( "(" );
 		if ( context.addGeneratedDate() ) {
-			generatedAnnotation.append( "\", date = \"" )
-					.append( SIMPLE_DATE_FORMAT.get().format( new Date() ) )
-					.append( "\")" );
+			generatedAnnotation
+					.append( "value = " );
 		}
-		else {
-			generatedAnnotation.append( "\")" );
+		generatedAnnotation
+				.append( "\"" )
+				.append( JPAMetaModelEntityProcessor.class.getName() )
+				.append( "\"" );
+		if ( context.addGeneratedDate() ) {
+			generatedAnnotation
+					.append( ", date = " )
+					.append( "\"" )
+					.append( SIMPLE_DATE_FORMAT.get().format( new Date() ) )
+					.append( "\"" );
 		}
+		generatedAnnotation.append( ")" );
 		return generatedAnnotation.toString();
 	}
 

tooling/metamodel-generator/src/main/java/org/hibernate/jpamodelgen/JPAMetaModelEntityProcessor.java

@@ -90,6 +90,12 @@ public void init(ProcessingEnvironment env) {
 			boolean addGeneratedAnnotation = Boolean.parseBoolean( tmp );
 			context.setAddGeneratedAnnotation( addGeneratedAnnotation );
 		}
+		else {
+			PackageElement jakartaAnnotationPackage =
+					context.getProcessingEnvironment().getElementUtils()
+							.getPackageElement( "jakarta.annotation" );
+			context.setAddGeneratedAnnotation( jakartaAnnotationPackage != null );
+		}
 
 		tmp = env.getOptions().get( JPAMetaModelEntityProcessor.ADD_GENERATION_DATE );
 		boolean addGenerationDate = Boolean.parseBoolean( tmp );

tooling/metamodel-generator/src/test/java/org/hibernate/jpamodelgen/test/generatedannotation/GeneratedAnnotationTest.java

@@ -28,7 +28,7 @@ public void testGeneratedAnnotationNotGenerated() {
 
 		// need to check the source because @Generated is not a runtime annotation
 		String metaModelSource = getMetaModelSourceAsString( TestEntity.class );
-		String generatedString = "@Generated(value = \"org.hibernate.jpamodelgen.JPAMetaModelEntityProcessor\")";
+		String generatedString = "@Generated(\"org.hibernate.jpamodelgen.JPAMetaModelEntityProcessor\")";
 		assertTrue( "@Generated should be added to the metamodel.", metaModelSource.contains( generatedString ) );
 	}
 }