Skip to content

Commit b3207ee

Browse files
jmartiskvladmihalcea
authored andcommitted
HHH-10457 fix derived identity tests
1 parent 3420733 commit b3207ee

File tree

13 files changed

+33
-19
lines changed

13 files changed

+33
-19
lines changed

hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e2/a/Dependent.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ public class Dependent {
1717

1818
@Id @ManyToOne
1919
@JoinColumns({
20-
@JoinColumn(name="FK1", referencedColumnName="firstName"),
21-
@JoinColumn(name="FK2", referencedColumnName="lastName")
20+
@JoinColumn(name="FK1", referencedColumnName="firstName", nullable = false),
21+
@JoinColumn(name="FK2", referencedColumnName="lastName", nullable = false)
2222
})
2323
Employee emp;
2424
}

hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e3/a/Dependent.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ public class Dependent {
1919

2020
@Id
2121
@JoinColumns({
22-
@JoinColumn(name = "FK1", referencedColumnName = "firstName"),
23-
@JoinColumn(name = "FK2", referencedColumnName = "lastName")
22+
@JoinColumn(name = "FK1", referencedColumnName = "firstName", nullable = false),
23+
@JoinColumn(name = "FK2", referencedColumnName = "lastName", nullable = false)
2424
})
2525
@ManyToOne
2626
Employee emp;

hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e3/b/Dependent.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public class Dependent {
2121

2222
@MapsId("empPK")
2323
@JoinColumns({
24-
@JoinColumn(name = "FK1", referencedColumnName = "FIRSTNAME"),
25-
@JoinColumn(name = "FK2", referencedColumnName = "lastName")
24+
@JoinColumn(name = "FK1", referencedColumnName = "FIRSTNAME", nullable = false),
25+
@JoinColumn(name = "FK2", referencedColumnName = "lastName", nullable = false)
2626
})
2727
@ManyToOne
2828
Employee emp;

hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e3/b2/Dependent.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import javax.persistence.EmbeddedId;
44
import javax.persistence.Entity;
5+
import javax.persistence.JoinColumn;
6+
import javax.persistence.JoinColumns;
57
import javax.persistence.ManyToOne;
68
import javax.persistence.MapsId;
79

@@ -13,5 +15,6 @@ public class Dependent {
1315

1416
@MapsId("empPK")
1517
@ManyToOne
18+
@JoinColumns( { @JoinColumn(nullable = false), @JoinColumn(nullable = false) })
1619
Employee emp;
1720
}
Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
package org.hibernate.test.annotations.derivedidentities.e3.b2;
22

3-
import javax.persistence.Embeddable;
43
import java.io.Serializable;
4+
import javax.persistence.Column;
5+
import javax.persistence.Embeddable;
56

67
@Embeddable
78
public class EmployeeId implements Serializable {
8-
String firstName;
9-
String lastName;
9+
@Column(length = 80) // for some reason db2 complains about too large PK if this is set to default (255)
10+
String firstName;
11+
String lastName;
1012
}

hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e3/b2/Policy.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import javax.persistence.EmbeddedId;
44
import javax.persistence.Entity;
5+
import javax.persistence.JoinColumn;
6+
import javax.persistence.JoinColumns;
57
import javax.persistence.ManyToOne;
68
import javax.persistence.MapsId;
79

@@ -13,6 +15,7 @@ public class Policy {
1315

1416
@MapsId("depPK")
1517
@ManyToOne
18+
@JoinColumns( { @JoinColumn(nullable = false), @JoinColumn(nullable = false), @JoinColumn(nullable = false) })
1619
Dependent dep;
1720

1821
}
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
package org.hibernate.test.annotations.derivedidentities.e3.b2;
22

3-
import javax.persistence.Embeddable;
43
import java.io.Serializable;
4+
import javax.persistence.Column;
5+
import javax.persistence.Embeddable;
56

67
@Embeddable
78
public class PolicyId implements Serializable {
9+
@Column(length = 80) // for some reason db2 complains about too large PK if this is set to default (255)
810
String type;
911
DependentId depPK;
1012
}

hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e3/b3/Dependent.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ public class Dependent {
99
DependentId id;
1010

1111
@JoinColumns({
12-
@JoinColumn(name = "FIRSTNAME", referencedColumnName = "FIRSTNAME"),
13-
@JoinColumn(name = "LASTNAME", referencedColumnName = "lastName")
12+
@JoinColumn(name = "FIRSTNAME", referencedColumnName = "FIRSTNAME", nullable = false),
13+
@JoinColumn(name = "LASTNAME", referencedColumnName = "lastName", nullable = false)
1414
})
1515
@MapsId("empPK")
1616
@ManyToOne
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
package org.hibernate.test.annotations.derivedidentities.e3.b3;
22

3+
import javax.persistence.Column;
34
import javax.persistence.Embeddable;
45
import java.io.Serializable;
56

67
@Embeddable
78
public class EmployeeId implements Serializable {
9+
@Column(length = 80) // for some reason db2 complains about too large PK if this is set to default (255)
810
String firstName;
911
String lastName;
1012
}

hibernate-core/src/test/java/org/hibernate/test/annotations/derivedidentities/e3/b3/Policy.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ public class Policy {
88
PolicyId id;
99

1010
@JoinColumns({
11-
@JoinColumn(name = "FIRSTNAME", referencedColumnName = "FIRSTNAME"),
12-
@JoinColumn(name = "LASTNAME", referencedColumnName = "lastName"),
13-
@JoinColumn(name = "NAME", referencedColumnName = "Name")
11+
@JoinColumn(name = "FIRSTNAME", referencedColumnName = "FIRSTNAME", nullable = false),
12+
@JoinColumn(name = "LASTNAME", referencedColumnName = "lastName", nullable = false),
13+
@JoinColumn(name = "NAME", referencedColumnName = "Name", nullable = false)
1414
})
1515
@MapsId("depPK")
1616
@ManyToOne

0 commit comments

Comments
 (0)