Skip to content

Commit b68eacb

Browse files
mbelladebeikov
authored andcommitted
HHH-15900 Fix failing tests on TiDB due to missing trigger support
1 parent 04b7706 commit b68eacb

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/generated/GeneratedTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717
import org.hibernate.testing.orm.junit.RequiresDialect;
1818
import org.hibernate.testing.orm.junit.SessionFactory;
1919
import org.hibernate.testing.orm.junit.SessionFactoryScope;
20+
import org.hibernate.testing.orm.junit.SkipForDialect;
21+
22+
import org.hibernate.dialect.TiDBDialect;
2023
import org.hibernate.tool.hbm2ddl.SchemaExport;
2124
import org.hibernate.tool.schema.TargetType;
2225
import org.junit.jupiter.api.Test;
@@ -44,6 +47,7 @@
4447
@RequiresDialect(H2Dialect.class)
4548
@RequiresDialect(DB2Dialect.class)
4649
@RequiresDialect(SQLServerDialect.class)
50+
@SkipForDialect(dialectClass = TiDBDialect.class, reason = "TiDB does not support triggers")
4751
public class GeneratedTest {
4852

4953
@Test

hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/select/SelectGeneratorTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import org.hibernate.dialect.OracleDialect;
1717
import org.hibernate.dialect.PostgreSQLDialect;
1818
import org.hibernate.dialect.SQLServerDialect;
19+
import org.hibernate.dialect.TiDBDialect;
1920
import org.hibernate.tool.hbm2ddl.SchemaExport;
2021
import org.hibernate.tool.schema.TargetType;
2122

@@ -24,6 +25,7 @@
2425
import org.hibernate.testing.orm.junit.RequiresDialect;
2526
import org.hibernate.testing.orm.junit.SessionFactory;
2627
import org.hibernate.testing.orm.junit.SessionFactoryScope;
28+
import org.hibernate.testing.orm.junit.SkipForDialect;
2729
import org.junit.jupiter.api.Test;
2830

2931
import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -42,6 +44,7 @@
4244
@RequiresDialect(MySQLDialect.class)
4345
@RequiresDialect(DB2Dialect.class)
4446
@RequiresDialect(SQLServerDialect.class)
47+
@SkipForDialect(dialectClass = TiDBDialect.class, reason = "TiDB does not support triggers")
4548
public class SelectGeneratorTest {
4649

4750
@Test

hibernate-core/src/test/java/org/hibernate/orm/test/generatedkeys/selectannotated/SelectGeneratorTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717
import org.hibernate.testing.orm.junit.RequiresDialect;
1818
import org.hibernate.testing.orm.junit.SessionFactory;
1919
import org.hibernate.testing.orm.junit.SessionFactoryScope;
20+
import org.hibernate.testing.orm.junit.SkipForDialect;
21+
22+
import org.hibernate.dialect.TiDBDialect;
2023
import org.hibernate.tool.hbm2ddl.SchemaExport;
2124
import org.hibernate.tool.schema.TargetType;
2225
import org.junit.jupiter.api.Test;
@@ -44,6 +47,7 @@
4447
@RequiresDialect(H2Dialect.class)
4548
@RequiresDialect(DB2Dialect.class)
4649
@RequiresDialect(SQLServerDialect.class)
50+
@SkipForDialect(dialectClass = TiDBDialect.class, reason = "TiDB does not support triggers")
4751
public class SelectGeneratorTest {
4852

4953
@Test

0 commit comments

Comments
 (0)