Skip to content

Commit c1767ad

Browse files
committed
HHH-16900 Rework also the MutationGroup APIs
1 parent c608ee3 commit c1767ad

File tree

3 files changed

+15
-22
lines changed

3 files changed

+15
-22
lines changed

hibernate-core/src/main/java/org/hibernate/sql/model/ast/MutationGroup.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
import java.util.function.BiConsumer;
1010

11-
import org.hibernate.sql.model.MutationOperation;
1211
import org.hibernate.sql.model.MutationTarget;
1312
import org.hibernate.sql.model.MutationType;
1413

@@ -25,9 +24,9 @@ public interface MutationGroup {
2524

2625
int getNumberOfTableMutations();
2726

28-
<O extends MutationOperation, M extends TableMutation<O>> M getSingleTableMutation();
27+
TableMutation getSingleTableMutation();
2928

30-
<O extends MutationOperation, M extends TableMutation<O>> M getTableMutation(String tableName);
29+
TableMutation getTableMutation(String tableName);
3130

32-
<O extends MutationOperation, M extends TableMutation<O>> void forEachTableMutation(BiConsumer<Integer, M> action);
31+
void forEachTableMutation(BiConsumer<Integer, TableMutation> action);
3332
}

hibernate-core/src/main/java/org/hibernate/sql/model/internal/MutationGroupSingle.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import java.util.Locale;
1010
import java.util.function.BiConsumer;
1111

12-
import org.hibernate.sql.model.MutationOperation;
1312
import org.hibernate.sql.model.MutationTarget;
1413
import org.hibernate.sql.model.MutationType;
1514
import org.hibernate.sql.model.ast.MutationGroup;
@@ -51,22 +50,19 @@ public int getNumberOfTableMutations() {
5150
}
5251

5352
@Override
54-
public <O extends MutationOperation, M extends TableMutation<O>> M getSingleTableMutation() {
55-
//noinspection unchecked
56-
return (M) tableMutation;
53+
public TableMutation getSingleTableMutation() {
54+
return tableMutation;
5755
}
5856

5957
@Override
60-
public <O extends MutationOperation, M extends TableMutation<O>> M getTableMutation(String tableName) {
58+
public TableMutation getTableMutation(String tableName) {
6159
assert tableMutation.getMutatingTable().getTableName().equals( tableName );
62-
//noinspection unchecked
63-
return (M) tableMutation;
60+
return tableMutation;
6461
}
6562

6663
@Override
67-
public <O extends MutationOperation, M extends TableMutation<O>> void forEachTableMutation(BiConsumer<Integer, M> action) {
68-
//noinspection unchecked
69-
action.accept( 0, (M) tableMutation );
64+
public void forEachTableMutation(BiConsumer<Integer, TableMutation> action) {
65+
action.accept( 0, tableMutation );
7066
}
7167

7268
@Override

hibernate-core/src/main/java/org/hibernate/sql/model/internal/MutationGroupStandard.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import java.util.List;
1010
import java.util.function.BiConsumer;
1111

12-
import org.hibernate.sql.model.MutationOperation;
1312
import org.hibernate.sql.model.MutationTarget;
1413
import org.hibernate.sql.model.MutationType;
1514
import org.hibernate.sql.model.ast.MutationGroup;
@@ -50,29 +49,28 @@ public int getNumberOfTableMutations() {
5049
}
5150

5251
@Override
53-
public <O extends MutationOperation, M extends TableMutation<O>> M getSingleTableMutation() {
52+
public TableMutation getSingleTableMutation() {
5453
throw new IllegalStateException( "Group contains multiple table mutations : " + mutationTarget.getNavigableRole() );
5554
}
5655

5756
@Override
58-
public <O extends MutationOperation, M extends TableMutation<O>> M getTableMutation(String tableName) {
57+
public TableMutation getTableMutation(String tableName) {
5958
for ( int i = 0; i < tableMutationList.size(); i++ ) {
6059
final TableMutation<?> tableMutation = tableMutationList.get( i );
6160
if ( tableMutation != null ) {
6261
if ( tableMutation.getMutatingTable().getTableName().equals( tableName ) ) {
63-
//noinspection unchecked
64-
return (M) tableMutation;
62+
return tableMutation;
6563
}
6664
}
6765
}
6866
return null;
6967
}
7068

7169
@Override
72-
public <O extends MutationOperation, M extends TableMutation<O>> void forEachTableMutation(BiConsumer<Integer, M> action) {
70+
public void forEachTableMutation(BiConsumer<Integer, TableMutation> action) {
7371
for ( int i = 0; i < tableMutationList.size(); i++ ) {
74-
//noinspection unchecked
75-
action.accept( i, (M)tableMutationList.get( i ) );
72+
action.accept( i, tableMutationList.get( i ) );
7673
}
7774
}
75+
7876
}

0 commit comments

Comments
 (0)