HHH-11739 - globally_quoted_identifiers_skip_column_definitions property does the opposite of what the doc describes

dreab8 · dreab8 · commit e950957b89dc · 2017-09-01T14:31:03.000+02:00
diff --git a/hibernate-core/src/main/java/org/hibernate/engine/jdbc/env/internal/NormalizingIdentifierHelperImpl.java b/hibernate-core/src/main/java/org/hibernate/engine/jdbc/env/internal/NormalizingIdentifierHelperImpl.java
@@ -93,7 +93,7 @@ public Identifier toIdentifier(String text, boolean quoted) {
 
 	@Override
 	public Identifier applyGlobalQuoting(String text) {
-		return Identifier.toIdentifier( text, globallyQuoteIdentifiers && globallyQuoteIdentifiersSkipColumnDefinitions );
+		return Identifier.toIdentifier( text, globallyQuoteIdentifiers && !globallyQuoteIdentifiersSkipColumnDefinitions );
 	}
 
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ public Identifier toIdentifier(String text, boolean quoted) {`
`93`	`93`
`94`	`94`	`@Override`
`95`	`95`	`public Identifier applyGlobalQuoting(String text) {`
`96`		`- return Identifier.toIdentifier( text, globallyQuoteIdentifiers && globallyQuoteIdentifiersSkipColumnDefinitions );`
	`96`	`+ return Identifier.toIdentifier( text, globallyQuoteIdentifiers && !globallyQuoteIdentifiersSkipColumnDefinitions );`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`@Override`