propose @DialectOverride annotation #4537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
commented
Dec 29, 2021
| @@ -94,7 +96,8 @@ void tearDown(SessionFactoryScope scope) { | |||
|
|
|||
| private Double rate; | |||
|
|
|||
| @Formula(value = "credit * rate") | |||
| @Formula(value = "credit * rate", | |||
| overrides = @DialectOverride(dialect = H2Dialect.class, value ="rate * credit") ) | |||
| private Double interest; | |||
There was a problem hiding this comment.
Here's an example of how you might use it, but it's much more general than this.
gavinking
force-pushed
the
dialect-override
branch
from
336f4ce
to
feec9a0
Compare
gavinking
force-pushed
the
dialect-override
branch
from
feec9a0
to
4f6c449
Compare
|
Currently the API for this looks like: @Formula(value = "credit * rate",
overrides = @DialectOverride(dialect = H2Dialect.class, value = "rate * credit") )I guess an alternative way to do it, that has less impact on the existing annotations, would be to write: @Formula(value = "credit * rate")
@DialectOverride(annotation = Formula.class, dialect = H2Dialect.class, value = "rate * credit")I'm unclear on which option is "better". I guess they're pretty equivalent. |
gavinking
force-pushed
the
dialect-override
branch
from
4f6c449
to
5b35ba4
Compare
gavinking
force-pushed
the
dialect-override
branch
from
5b35ba4
to
2f5dae4
Compare
This allows the use of native SQL in annotations of portable programs. We've needed something like this for a long time.
gavinking
force-pushed
the
dialect-override
branch
from
2f5dae4
to
a609cff
Compare
|
Superseded by #4607. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the use of native SQL in annotations of portable programs.
We've needed something like this for a long time.