HSEARCH-4070 Take the configured totalHitCountThreshold into account for Lucene scrolls

Signed-off-by: Yoann Rodière <yoann@hibernate.org>

Author: yrodiere

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchQueryImpl.java

@@ -121,8 +121,7 @@ public LuceneSearchScroll<H> scroll(int chunkSize) {
 		HibernateSearchMultiReader indexReader = HibernateSearchMultiReader.open(
 				indexNames, searchContext.indexes().elements(), routingKeys );
 		return new LuceneSearchScrollImpl<>( queryOrchestrator, workFactory, searchContext, routingKeys, timeoutManager,
-				searcher, indexReader, chunkSize
-		);
+				searcher, totalHitCountThreshold( true ), indexReader, chunkSize );
 	}
 
 	@Override

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearchScrollImpl.java

@@ -36,6 +36,7 @@ public class LuceneSearchScrollImpl<H> implements LuceneSearchScroll<H> {
 	private final Set<String> routingKeys;
 	private final LuceneTimeoutManager timeoutManager;
 	private final LuceneSearcher<LuceneLoadableSearchResult<H>, LuceneExtractableSearchResult<H>> searcher;
+	private final int totalHitCountThreshold;
 
 	// specific to this scroll instance:
 	private final HibernateSearchMultiReader indexReader;
@@ -51,13 +52,15 @@ public LuceneSearchScrollImpl(LuceneSyncWorkOrchestrator queryOrchestrator,
 			Set<String> routingKeys,
 			LuceneTimeoutManager timeoutManager,
 			LuceneSearcher<LuceneLoadableSearchResult<H>, LuceneExtractableSearchResult<H>> searcher,
+			int totalHitCountThreshold,
 			HibernateSearchMultiReader indexReader, int chunkSize) {
 		this.queryOrchestrator = queryOrchestrator;
 		this.workFactory = workFactory;
 		this.searchContext = searchContext;
 		this.routingKeys = routingKeys;
 		this.timeoutManager = timeoutManager;
 		this.searcher = searcher;
+		this.totalHitCountThreshold = totalHitCountThreshold;
 		this.indexReader = indexReader;
 		this.chunkSize = chunkSize;
 		this.currentPageLimit = chunkSize * 4; // Will fetch the topdocs for the first 4 pages initially
@@ -90,7 +93,9 @@ private LuceneSearchScrollResult<H> doNext() {
 				currentPageLimit *= 2;
 			}
 			currentPageOffset = nextChunkOffset;
-			currentPage = doSubmitWithIndexReader( workFactory.scroll( searcher, currentPageOffset, currentPageLimit ), indexReader );
+			currentPage = doSubmitWithIndexReader(
+					workFactory.scroll( searcher, currentPageOffset, currentPageLimit, totalHitCountThreshold ),
+					indexReader );
 		}
 
 		int nextChunkStartIndexInPage = nextChunkOffset - currentPageOffset;

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/search/query/impl/LuceneSearcherImpl.java

@@ -74,8 +74,9 @@ public LuceneLoadableSearchResult<H> search(IndexSearcher indexSearcher,
 
 	@Override
 	public LuceneExtractableSearchResult<H> scroll(IndexSearcher indexSearcher,
-			IndexReaderMetadataResolver metadataResolver, int offset, int limit) throws IOException {
-		return doSearch( indexSearcher, metadataResolver, offset, limit, Integer.MAX_VALUE );
+			IndexReaderMetadataResolver metadataResolver,
+			int offset, int limit, int totalHitCountThreshold) throws IOException {
+		return doSearch( indexSearcher, metadataResolver, offset, limit, totalHitCountThreshold );
 	}
 
 	private LuceneExtractableSearchResult<H> doSearch(IndexSearcher indexSearcher,

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneSearcher.java

@@ -21,7 +21,7 @@ R search(IndexSearcher indexSearcher, IndexReaderMetadataResolver metadataResolv
 			int offset, Integer limit, int totalHitCountThreshold) throws IOException;
 
 	ER scroll(IndexSearcher indexSearcher, IndexReaderMetadataResolver metadataResolver,
-			int offset, int limit) throws IOException;
+			int offset, int limit, int totalHitCountThreshold) throws IOException;
 
 	int count(IndexSearcher indexSearcher) throws IOException;
 

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWorkFactory.java

@@ -40,7 +40,7 @@ SingleDocumentIndexingWork update(String tenantId, String entityTypeName, Object
 
 	<R> ReadWork<R> search(LuceneSearcher<R, ?> searcher, Integer offset, Integer limit, int totalHitCountThreshold);
 
-	<ER> ReadWork<ER> scroll(LuceneSearcher<?, ER> searcher, int offset, int limit);
+	<ER> ReadWork<ER> scroll(LuceneSearcher<?, ER> searcher, int offset, int limit, int totalHitCountThreshold);
 
 	ReadWork<Integer> count(LuceneSearcher<?, ?> searcher);
 

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/LuceneWorkFactoryImpl.java

@@ -99,8 +99,8 @@ public <R> ReadWork<R> search(LuceneSearcher<R, ?> searcher, Integer offset, Int
 	}
 
 	@Override
-	public <ER> ReadWork<ER> scroll(LuceneSearcher<?, ER> searcher, int offset, int limit) {
-		return new ScrollWork<>( searcher, offset, limit );
+	public <ER> ReadWork<ER> scroll(LuceneSearcher<?, ER> searcher, int offset, int limit, int totalHitCountThreshold) {
+		return new ScrollWork<>( searcher, offset, limit, totalHitCountThreshold );
 	}
 
 	@Override

backend/lucene/src/main/java/org/hibernate/search/backend/lucene/work/impl/ScrollWork.java

@@ -23,19 +23,22 @@ public class ScrollWork<ER> implements ReadWork<ER> {
 
 	private final int offset;
 	private final int limit;
+	private final int totalHitCountThreshold;
 
-	ScrollWork(LuceneSearcher<?, ER> searcher, int offset, int limit) {
+	ScrollWork(LuceneSearcher<?, ER> searcher, int offset, int limit, int totalHitCountThreshold) {
 		this.offset = offset;
 		this.limit = limit;
 		this.searcher = searcher;
+		this.totalHitCountThreshold = totalHitCountThreshold;
 	}
 
 	@Override
 	public ER execute(ReadWorkExecutionContext context) {
 		try {
 			IndexSearcher indexSearcher = context.createSearcher();
 
-			return searcher.scroll( indexSearcher, context.getIndexReaderMetadataResolver(), offset, limit );
+			return searcher.scroll( indexSearcher, context.getIndexReaderMetadataResolver(), offset, limit,
+					totalHitCountThreshold );
 		}
 		catch (IOException e) {
 			throw log.ioExceptionOnQueryExecution( searcher.getLuceneQueryForExceptions(), context.getEventContext(), e );