HSEARCH-4920 Do not check for source modifications in Elasticsearch upgrade job

Author: marko-bekhta

ci/dependency-update/Jenkinsfile

@@ -13,30 +13,36 @@ Map settings() {
 		case 'orm6.2':
 			return [
 					updateProperties: ['version.org.hibernate.orm'],
-					onlyRunTestDependingOn: ['hibernate-search-mapper-orm']
+					onlyRunTestDependingOn: ['hibernate-search-mapper-orm'],
+					requiresSourceModifications: true
 			]
 		case 'orm6.3':
 			return [
 					updateProperties: ['version.org.hibernate.orm'],
-					onlyRunTestDependingOn: ['hibernate-search-mapper-orm']
+					onlyRunTestDependingOn: ['hibernate-search-mapper-orm'],
+					requiresSourceModifications: true
 			]
 		case 'lucene9':
 			return [
 					updateProperties: ['version.org.apache.lucene'],
 					onlyRunTestDependingOn: ['hibernate-search-backend-lucene'],
+					requiresSourceModifications: true
 			]
 		case 'lucene10':
 			return [
 					updateProperties: ['version.org.apache.lucene'],
 					onlyRunTestDependingOn: ['hibernate-search-backend-lucene'],
+					requiresSourceModifications: true
 			]
 		case 'elasticsearch-latest':
 			return [
 					// There are no properties to update in this case.
 					updateProperties: [],
 					onlyRunTestDependingOn: ['hibernate-search-backend-elasticsearch'],
 					// We want to use the snapshot version of an image from the ES registry since that's where they are publishing their snapshots.
-					additionalMavenArgs: '-Dtest.elasticsearch.run.elastic.image.name=docker.elastic.co/elasticsearch/elasticsearch -Dtest.elasticsearch.run.elastic.image.tag=master-SNAPSHOT'
+					additionalMavenArgs: '-Dtest.elasticsearch.run.elastic.image.name=docker.elastic.co/elasticsearch/elasticsearch -Dtest.elasticsearch.run.elastic.image.tag=master-SNAPSHOT',
+					// This job won't change the versions in the pom. We are passing the latest Elasticsearch version through an additional maven argument `-D`
+					requiresSourceModifications: false
 			]
 		default:
 			return [:]
@@ -161,7 +167,7 @@ pipeline {
 								sh "ci/dependency-update/perform-update.sh ${env.DEPENDENCY_UPDATE_NAME} '${settings().updateProperties?.join(",") ?: ''}'"
 							}
 							script {
-								if (0 != sh(script: "git diff origin/${BRANCH_NAME} | grep -q '.'", returnStatus: true)) {
+								if (settings().requiresSourceModifications && 0 != sh(script: "git diff origin/${BRANCH_NAME} | grep -q '.'", returnStatus: true)) {
 									error "This job does not seem to update any dependency; perhaps it is misconfigured? The source code has not been updated, neither by merging a WIP branch nor by updating version properties."
 								}
 							}