proposal: math: Go 2: use explicit types for limit constants #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
牛逼 |
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
=======================================
Coverage 73.49% 73.49%
=======================================
Files 24 24
Lines 3150 3150
=======================================
Hits 2315 2315
Misses 586 586
Partials 249 249
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Thank you @assimon!! |
|
@hibiken Pleasure, looking forward to the merger soon, great project!🎉 |
|
❤ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
math: MaxInt64 overflows int on ARM，
Refer to this issue:
golang/go#23087
math.MaxInt64 and friends are untyped constants. This causes confusion when using the constants on 32-bit systems.