[FEATURE REQUEST] maxArchiveSize and archivedExpirationInDays should be configurable at the server level #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojanz
reviewed
Aug 30, 2023
| @@ -869,6 +896,9 @@ return redis.status_reply("OK")`) | |||
| // Archive sends the given task to archive, attaching the error message to the task. | |||
| // It also trims the archive by timestamp and set size. | |||
| func (r *RDB) Archive(ctx context.Context, msg *base.TaskMessage, errMsg string) error { | |||
| if *(r.config.MaxArchiveSize) <= 0 { | |||
| return nil | |||
There was a problem hiding this comment.
Won't this just leave the task in the original queue? We probably want to delete it instead?
r.DeleteTask() doesn't work on active tasks right now, so perhaps we need a hint from @hibiken
There was a problem hiding this comment.
This is fine as the author intended that setting anything < 1 should never delete anything. But, another issue is that if the configs are set < 0, a default value of 1 is used that will trigger an archive which is not intended behavior.
This was referenced May 7, 2024
|
Close this as stale. Another PR should be opened in favor of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#441