-
Notifications
You must be signed in to change notification settings - Fork 38
Support host os independent timezone db #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot for your contribution 🥇 Two very small comments, please take a look when you have time.
Changes look good on digital paper, need to give it real spin though, which I will do tonight or tomorrow. Thanks so far 🌷 |
There are a couple of env variables that might be useful to document:
This is what a running instance log looks like (
|
@mterron I see you made a couple more changes, what is the current state of this PR? Is there anything you need help with? |
It is as generic as I can make it (all the latest commits removed things
that work in my specific environment but not in a default installation).
Please take it for a spin and see if it works for you.
…On Fri, 10 May 2019, 02:21 Hidde Beydals, ***@***.***> wrote:
@mterron <https://github.com/mterron> I see you made a couple more
changes, what is the current state of this PR? Is there anything you need
help with?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABB2XW7JO3NPJFYCSDQYIXLPUQXOPANCNFSM4HK4LR3Q>
.
|
@mterron failing CI is not related to the content of my changes, a Google server is having issues. Please take a look at the changes I made, if they look alright to you I will smash a couple of commits together to keep the I am interested in if the modified |
This commit adds support for independently maintaining an up-to-date timezone database. It adds requirements of internet access for the cronjobber-updatetz image to download updated files. The cronjobber-updatetz support standard proxy env variables.
As the internet has it wrong[1] and the nobody user should only be used as a placeholder for "unmapped" users and user ids in NFS tree exports[2]. [1]: https://wiki.ubuntu.com/nobody [2]: https://askubuntu.com/questions/329714/what-is-the-purpose-of-the-nobody-user/674397#674397
Thanks again for your contribution. I have put out releases of both images, as soon as |
This commit adds support for independently maintaining an up-to-date timezone database as per #9
It adds requirements of internet access for the
cronjobber-updatetz
image to download updated files. Thecronjobber-updatetz
support standard proxy env variables.