Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Support host os independent timezone db #10

Merged
merged 4 commits into from
May 9, 2019
Merged

Support host os independent timezone db #10

merged 4 commits into from
May 9, 2019

Conversation

mterron
Copy link
Contributor

@mterron mterron commented May 5, 2019

This commit adds support for independently maintaining an up-to-date timezone database as per #9

It adds requirements of internet access for the cronjobber-updatetz image to download updated files. The cronjobber-updatetz support standard proxy env variables.

Copy link
Owner

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot for your contribution 🥇 Two very small comments, please take a look when you have time.

deploy/deploy.yaml Outdated Show resolved Hide resolved
updatetz/docker-entrypoint.sh Outdated Show resolved Hide resolved
@mterron mterron changed the title Support independent timezone db Support host os independent timezone db May 6, 2019
@hiddeco
Copy link
Owner

hiddeco commented May 7, 2019

Changes look good on digital paper, need to give it real spin though, which I will do tonight or tomorrow. Thanks so far 🌷

updatetz/Dockerfile Outdated Show resolved Hide resolved
@mterron
Copy link
Contributor Author

mterron commented May 8, 2019

There are a couple of env variables that might be useful to document:

  • TZPV is the location where the persistent volume for the timezone database is mounted on the updatetz container. (/tmp/zoneinfo by default)
  • REFRESH_PERIOD is how often the updatetz container will look for updates (1 week by default).

This is what a running instance log looks like (REFRESH_INTERVAL set to 30s for demo purposes):

2019-05-08T02:12:44+0000 Local Time Zone database updated to version 2019a on /tmp/zoneinfo
2019-05-08T02:13:15+0000 Local Time Zone database is up to date
2019-05-08T02:13:46+0000 Local Time Zone database is up to date

@hiddeco
Copy link
Owner

hiddeco commented May 9, 2019

@mterron I see you made a couple more changes, what is the current state of this PR? Is there anything you need help with?

@mterron
Copy link
Contributor Author

mterron commented May 9, 2019 via email

@hiddeco
Copy link
Owner

hiddeco commented May 9, 2019

@mterron failing CI is not related to the content of my changes, a Google server is having issues.

Please take a look at the changes I made, if they look alright to you I will smash a couple of commits together to keep the master history clean and merge it. 🌞

I am interested in if the modified securityContext config is still failing on OpenShift by the way, so if you have some time to look into this that would be awesome.

deploy/deploy-updatetz.yaml Outdated Show resolved Hide resolved
deploy/deploy-updatetz.yaml Outdated Show resolved Hide resolved
deploy/deploy.yaml Outdated Show resolved Hide resolved
updatetz/Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
mterron and others added 4 commits May 10, 2019 01:15
This commit adds support for independently maintaining an up-to-date
timezone database. It adds requirements of internet access for the
cronjobber-updatetz image to download updated files.
The cronjobber-updatetz support standard proxy env variables.
As the internet has it wrong[1] and the nobody user should only be
used as a placeholder for "unmapped" users and user ids in NFS tree
exports[2].

[1]: https://wiki.ubuntu.com/nobody
[2]: https://askubuntu.com/questions/329714/what-is-the-purpose-of-the-nobody-user/674397#674397
@hiddeco hiddeco merged commit 91eaac6 into hiddeco:master May 9, 2019
@hiddeco
Copy link
Owner

hiddeco commented May 9, 2019

Thanks again for your contribution. I have put out releases of both images, as soon as 0.2.0 has been pushed to the registry, kubectl apply -f https://raw.githubusercontent.com/hiddeco/cronjobber/master/deploy/deploy-updatetz.yaml should do the job.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants