Fix expressionCache bug
#6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`expressionCache` is a plain object which will give a property from object prototype if `expression` is one of them e.g `toString`, `constructor` causing all sorts of unexpected behavior such as one seen in solidjs/solid-docs#175 example code that can fail ``` jsx('x', { children: 'constructor' }) jsx('x', { children: '__proto__' }) ```
mdynnl
commented
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expressionCacheis a plain object which will give a property from object prototype ifexpressionis one of them e.gtoString,constructorcausing all sorts of unexpected behavior such as one seen in solidjs/solid-docs#175example code that can fail
on a related note, this type of bug also affects
solid-js