Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Dashboards DTS #19310

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Improved Dashboards DTS #19310

merged 6 commits into from
Jul 6, 2023

Conversation

bre1470
Copy link
Member

@bre1470 bre1470 commented Jul 5, 2023

Improved TypeScript declarations to support classic bundles (minified and as source).

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

@highsoft-bot
Copy link
Collaborator

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
dashboards/dashboards.js 42.1 kB
144.4 kB
42.1 kB
144.4 kB
-13 B
-11 B
dashboards/modules/dashboards-plugin.js 12.9 kB
39.9 kB
12.9 kB
39.9 kB
-71 B
34 B

@bre1470 bre1470 marked this pull request as ready for review July 5, 2023 15:57
@bre1470 bre1470 changed the title Dashboards DTS Improved Dashboards DTS Jul 5, 2023
@bre1470 bre1470 added the Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. label Jul 5, 2023
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@pawellysy pawellysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bre1470 bre1470 merged commit b62a4dd into master Jul 6, 2023
@highsoft-bot highsoft-bot added this to the Dashboards-Next milestone Jul 6, 2023
@bre1470 bre1470 deleted the dash/fix-dts branch July 6, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Use on PR to add description as a bugfix in the generated changelog. Product: Highcharts Dashboards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants