-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/480-cache-directory-path #488
feature/480-cache-directory-path #488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
FYI, I tried to set
I'm using the following Dockerfile to create a Kubernetes-Pod with
... but I could only get it to work with these changes master...baroso:node-export-server:master in my own fork. And one other question arises, since Kubernetes logs to |
Also, when I want to enable the following options (as start arguments) ...
... but I get the following error message (on all calls to the server) ...
Does anyone know why this is not working in Docker? |
This is still not working as I believe it should. Whatever you put into HIGHCHARTS_CACHE_PATH gets appended to the executable path. This means that in the case of the node module version, it still has to be a sub-directory of the node_modules directory. Instead, if it is an absolute path, then it should use the absolute pathing. If it's a relative path, then it can be relative. If you also want to handle just a directory name (.cache) then this would require more logic, but should also be doable. |
Added the
cachePath
(HIGHCHARTS_CACHE_PATH
) option which allows you to change the default directory to which the scripts are saved which is a major problem on AWS Lambda where you do not have write permissions to the.cache
directory innode_modules
and thus,highcharts-export-server
does not work as expected.