Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Support from Protocols - Http2 Spike #205

Closed
eperinan opened this issue Mar 19, 2018 · 4 comments
Closed

HTTP Support from Protocols - Http2 Spike #205

eperinan opened this issue Mar 19, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@eperinan
Copy link
Contributor

This issue comes from #182.

After #203, we need to enable HTTP2 like this example https://github.com/http4s/http4s/blob/ecf32b9377997f17ed4c8858ec1471d0836d8522/examples/blaze/src/main/scala/com/example/http4s/blaze/BlazeHttp2Example.scala.

@eperinan eperinan self-assigned this Mar 19, 2018
@L-Lavigne
Copy link
Contributor

Just a quick note that HTTP/2 support with .enableHttp2() is ignored (with a logged warning) unless TLS is also enabled. I think this is done with .withSSLContext() but my quick testing with that wasn't conclusive. The http4s docs and issues seem a bit vague on the status of HTTP/2 support on the client side.

@eperinan eperinan assigned L-Lavigne and unassigned eperinan May 9, 2018
@juanpedromoreno
Copy link
Member

I think this spike has been already done by @L-Lavigne . Thanks for doing it!

@L-Lavigne
Copy link
Contributor

As discussed offline we'll keep this issue open for now, and find out if client-side HTTP/2 support in http4s/blaze is mature enough for us to use.

@L-Lavigne L-Lavigne reopened this May 9, 2018
@L-Lavigne L-Lavigne added enhancement New feature or request http labels May 23, 2018
@juanpedromoreno
Copy link
Member

This is probably a bit outdated. Closing it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants