Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support duration prefixes #8109

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

SpennyNDaJets
Copy link
Contributor

@SpennyNDaJets SpennyNDaJets commented Mar 26, 2024

Summary

Typing the duration in nanoseconds is burdensome on the user. Support using time suffixes to search numbers.

Supported suffixes:

h
m
s
ms
us
ns

https://www.loom.com/share/7c85288923864082bb9ce183fb39660b?sid=1a242ffd-02f6-467a-9354-6bb08191d45d

How did you test this change?

  1. Visit the traces page (/traces)
  2. Ensure duration is displayed on the table
  3. Search using the numerical operators -> >, >=, <, <=,
  • Correctly applies operator

Are there any deployment considerations?

N/A

Does this work require review from our design team?

N/A

Copy link

changeset-bot bot commented Mar 26, 2024

⚠️ No Changeset found

Latest commit: d3db98c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@SpennyNDaJets SpennyNDaJets marked this pull request as ready for review March 26, 2024 22:46
@SpennyNDaJets SpennyNDaJets requested review from a team and mayberryzane and removed request for a team March 26, 2024 22:46
@SpennyNDaJets SpennyNDaJets merged commit a53d972 into main Mar 27, 2024
13 checks passed
@SpennyNDaJets SpennyNDaJets deleted the spenny/support-duration-prefixes branch March 27, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants