Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working directory tree highlighting #680

Closed
ozlerhakan opened this issue Dec 20, 2014 · 9 comments
Closed

Working directory tree highlighting #680

ozlerhakan opened this issue Dec 20, 2014 · 9 comments
Labels

Comments

@ozlerhakan
Copy link
Contributor

Hi @isagalaev,

Probably, this purpose will not be provided by highlight.js since it deals with concrete language definitions. Considering this case, we just created a new language definition for tree structures. Perhaps, anyone can make use of it and contribute: https://github.com/asciidocfx/highlight-treeview.js

@Sannis
Copy link
Collaborator

Sannis commented Dec 20, 2014

I remember a page with third-party software that uses highlight.js was hosted on @isagalaev site. I think we can recreate such page in docs and mention highlight-treeview.js there.

@ozlerhakan
Copy link
Contributor Author

Sounds good @Sannis

@isagalaev
Copy link
Member

@ozlerhakan is it in any way related to https://github.com/Golmote/prism-treeview?

@ozlerhakan
Copy link
Contributor Author

The implementation of the treeview is not directly related at all. We implemented it from scratch. We only took data:urls (icons) from that site. We can mention it as "a tree structure for prims".

@Sannis
Copy link
Collaborator

Sannis commented Jan 10, 2015

Looking deeper this cannot be simply merged now due to data URLs for icons. Maybe we can come back after styles reorganisation in #348.

@Sannis Sannis added the on hold label Jan 10, 2015
@isagalaev
Copy link
Member

Just to confirm, I also think it would be useful to have it as a language: people do often display directory structures along with code snippets. I don't have an easy solution as to where put those icons either. They probably have to live in a separate style and we could document it somewhere.

@Sannis
Copy link
Collaborator

Sannis commented Jan 11, 2015

Yes, we can look how this language looks without any styles and make decision.

Anyway, I'll not close any issues with on hold label.

@isagalaev
Copy link
Member

So… I was thinking about this idea lately and it still feels to me like a bit of a stretch to bundle a very special case with a very special CSS along with the library. So I think we could just live with it being a nice derivative project until a better idea comes up.

@ozlerhakan thanks for doing this anyway!

@ozlerhakan
Copy link
Contributor Author

Np @isagalaev , You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants