Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Haskell added 'where' inside data block. Resolves #3753 #3754

Closed
wants to merge 1 commit into from

Conversation

Somarfagell
Copy link

Changes

The where keyword in the Haskell GADT syntax wasn't highlighted correctly, adding 'where' keyword inside the data block correct the issue.

Added 'where' keyword inside data block inside haskell.js

Checklist

  • Added markup tests
  • Updated the changelog at CHANGES.md

@joshgoebel
Copy link
Member

Nice, but is this also correct for type and newtype blocks also?

1 similar comment
@joshgoebel
Copy link
Member

Nice, but is this also correct for type and newtype blocks also?

@Somarfagell
Copy link
Author

Nice, but is this also correct for type and newtype blocks also?

I haven't checked, but I suppose it would work, Do you want me to check it? 👀

@joshgoebel
Copy link
Member

It should work [as in be highlighted], but is that correct and valid Haskell? I don't know when where is and isn't supposed to be a keyword.

@joshgoebel
Copy link
Member

Ping.

@joshgoebel
Copy link
Member

Closing older PRs without activity. When you have time to come back to this we can reopen.

@joshgoebel joshgoebel closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants