Update Haxe grammar #3789
Merged
Update Haxe grammar #3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
joshgoebel
reviewed
May 19, 2023
joshgoebel
reviewed
May 19, 2023
joshgoebel
reviewed
May 19, 2023
joshgoebel
reviewed
May 19, 2023
|
Could you rebase on main now that I fixed the test suite? |
|
Done! 👍 |
|
Also will need to update CHANGELOG |
joshgoebel
approved these changes
May 20, 2023
|
Hope that looks good! Edit: Updated with a bit more detail |
joshgoebel
approved these changes
May 21, 2023
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated
languages/haxe.jsto properly highlight some missing Haxe keywords and features.Checklist
$identifiers)finalkeyword (added in Haxe 4.0)iskeywordabstractmodule highlighting so doesn't conflict with abstract class, function, and new keyword.