Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10-7 update redone #5

Merged
merged 5 commits into from
Mar 26, 2021
Merged

10-7 update redone #5

merged 5 commits into from
Mar 26, 2021

Conversation

jf990
Copy link
Collaborator

@jf990 jf990 commented Mar 24, 2021

  • move Update for 10.6 #3 over to this branch
  • update to 10.7
  • changes test to use highlight instead of highlightAuto, use real test data
  • improve gitignore
  • adds -X method highlight improvement

@jf990 jf990 requested a review from joshgoebel March 24, 2021 23:16
@jf990 jf990 self-assigned this Mar 24, 2021
@jf990 jf990 mentioned this pull request Mar 24, 2021
Closed
joshgoebel
joshgoebel reviewed Mar 25, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
joshgoebel
joshgoebel reviewed Mar 25, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
joshgoebel
joshgoebel reviewed Mar 25, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
jf990 and others added 3 commits March 24, 2021 19:26
@jf990 @joshgoebel
Update README.md
3cef368 
Co-authored-by: Josh Goebel <me@joshgoebel.com>
@jf990 @joshgoebel
Update README.md
15a125d 
Co-authored-by: Josh Goebel <me@joshgoebel.com>
@jf990
improve README, address feedback
4c52a1c
@jf990 jf990 requested a review from joshgoebel March 25, 2021 19:42
@jf990
Copy link
Collaborator Author

jf990 commented Mar 25, 2021

@joshgoebel thanks for the feedback, comments addressed in latest commit.

joshgoebel
joshgoebel reviewed Mar 26, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
joshgoebel
joshgoebel approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that one thing.

@jf990 @joshgoebel
Update README.md
dc49259 
Co-authored-by: Josh Goebel <me@joshgoebel.com>
@jf990 jf990 merged commit 62269e4 into master Mar 26, 2021
@jf990 jf990 deleted the update-10-7-part-2 branch March 26, 2021 16:46
@jf990 jf990 mentioned this pull request Mar 26, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees

@jf990 jf990

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jf990 @joshgoebel