Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pdoc3 version back to pypi releases #94

Closed
davfsa opened this issue Aug 27, 2020 · 2 comments · Fixed by #96
Closed

Bump pdoc3 version back to pypi releases #94

davfsa opened this issue Aug 27, 2020 · 2 comments · Fixed by #96
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@davfsa
Copy link
Member

davfsa commented Aug 27, 2020

Pdoc3 V0.9 got released about 13h ago (at the time of writing this) which includes the lunr.js search that I madr.

This should be tested that it still builds and the search bar works correctly.

@davfsa davfsa added the enhancement New feature or request label Aug 27, 2020
@ghost
Copy link

ghost commented Aug 27, 2020

Can confirm that this no longer works with our set up using v0.9.0.

$ nox -spdoc
nox > Running session pdoc
nox > Creating virtual environment (virtualenv) using python in .nox/pdoc
nox > pip install -r requirements.txt
nox > pip install pdoc3~=0.9.0
nox > pip install sphobjinv
nox > python docs/patched_pdoc.py hikari --html --output-dir public --template-dir docs --force
/home/me/code/hikari/.nox/pdoc/lib/python3.8/site-packages/aiohttp/helpers.py:107: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
  def noop(*args, **kwargs):  # type: ignore
Traceback (most recent call last):
  File "docs/patched_pdoc.py", line 9, in <module>
    main()
  File "docs/patched_pdoc.py", line 5, in main
    cli.main()
  File "/home/me/code/hikari/.nox/pdoc/lib/python3.8/site-packages/pdoc/cli.py", line 537, in main
    modules = [pdoc.Module(module, docfilter=docfilter,
  File "/home/me/code/hikari/.nox/pdoc/lib/python3.8/site-packages/pdoc/cli.py", line 537, in <listcomp>
    modules = [pdoc.Module(module, docfilter=docfilter,
  File "/home/me/code/hikari/.nox/pdoc/lib/python3.8/site-packages/pdoc/__init__.py", line 640, in __init__
    self.doc[name] = Class(name, self, obj)
  File "/home/me/code/hikari/.nox/pdoc/lib/python3.8/site-packages/pdoc/__init__.py", line 952, in __init__
    for _name, obj in _getmembers_all(self.obj)
  File "/home/me/code/hikari/.nox/pdoc/lib/python3.8/site-packages/pdoc/__init__.py", line 907, in _getmembers_all
    names.update(_get_type_hints(obj).keys())
  File "/usr/lib/python3.8/typing.py", line 1232, in get_type_hints
    value = _eval_type(value, base_globals, localns)
  File "/usr/lib/python3.8/typing.py", line 270, in _eval_type
    return t._evaluate(globalns, localns)
  File "/usr/lib/python3.8/typing.py", line 518, in _evaluate
    eval(self.__forward_code__, globalns, localns),
  File "<string>", line 1, in <module>
NameError: name 'datetime' is not defined

@ghost ghost added the bug Something isn't working label Aug 27, 2020
@ghost ghost assigned davfsa Aug 27, 2020
@ghost ghost added the blocked This issue cannot yet be completed, or this PR is not yet ready to merge because of a dependency label Aug 27, 2020
@ghost
Copy link

ghost commented Aug 27, 2020

Looks like this is blocked by pdoc3/pdoc#245, which may or may not be a very simple fix, so for now I will leave this open and see what happens. :)

@ghost ghost mentioned this issue Aug 27, 2020
@ghost ghost removed the blocked This issue cannot yet be completed, or this PR is not yet ready to merge because of a dependency label Aug 28, 2020
@ghost ghost closed this as completed in #96 Aug 28, 2020
@ghost ghost added this to the 2.0.0 milestone Sep 4, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant