Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped to pdoc 0.9.0. #96

Merged
1 commit merged into from
Aug 28, 2020
Merged

Bumped to pdoc 0.9.0. #96

1 commit merged into from
Aug 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2020

Currently failing to build from pdoc issue https://github.com/pdoc3/pdoc/issues/245, so this
will need to be updated when that issue gets resolved or reverted.

Will close #94 once fixed.

@ghost ghost added bug Something isn't working documentation Improvements or additions to documentation blocked This issue cannot yet be completed, or this PR is not yet ready to merge because of a dependency devops Changes to quality control processes, CI, release processes labels Aug 27, 2020
@ghost ghost assigned davfsa Aug 27, 2020
@ghost ghost force-pushed the task/94-bump-pdoc3 branch from 6a98d61 to 0913f0a Compare August 27, 2020 14:33
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #96 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   79.94%   79.94%           
=======================================
  Files          78       78           
  Lines        9803     9804    +1     
  Branches     1241     1241           
=======================================
+ Hits         7837     7838    +1     
  Misses       1909     1909           
  Partials       57       57           
Impacted Files Coverage Δ
hikari/traits.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67ac63...e61ad6a. Read the comment docs.

@davfsa
Copy link
Member

davfsa commented Aug 27, 2020

The issue has been solved and this should now work.

Btw, since this is a bit in the scope of this pr, mind adding slots to the BotAware trait? Its missing them and a weakref_slot is being assigned to it

@ghost
Copy link
Author

ghost commented Aug 28, 2020

The issue has been solved and this should now work.

Btw, since this is a bit in the scope of this pr, mind adding slots to the BotAware trait? Its missing them and a weakref_slot is being assigned to it

On it.

@ghost ghost removed the blocked This issue cannot yet be completed, or this PR is not yet ready to merge because of a dependency label Aug 28, 2020
Currently failing to build from pdoc issue pdoc3/pdoc#245, so this
will need to be updated when that issue gets resolved or reverted.

Added missing slot to BotAware.

Froze isort to v5.4.2

Reformatted traits.
@ghost ghost force-pushed the task/94-bump-pdoc3 branch from 73cdd33 to e61ad6a Compare August 28, 2020 08:32
@ghost ghost requested a review from davfsa August 28, 2020 08:32
@ghost ghost merged commit 446d803 into master Aug 28, 2020
@ghost ghost deleted the task/94-bump-pdoc3 branch August 28, 2020 09:54
@ghost ghost added this to the 2.0.0 milestone Sep 4, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops Changes to quality control processes, CI, release processes documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump pdoc3 version back to pypi releases
1 participant