Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newly documented crossposting related endpoints and models. #147

Merged
4 commits merged into from
Sep 10, 2020

Conversation

FasterSpeeding
Copy link
Collaborator

Summary

Add newly documented crossposting related endpoints and models.

Checklist

  • [x ] I have run nox and all the pipelines have passed.
  • [ x] I have made unittests according to the code I have added/modified/deleted.

Related issues

@FasterSpeeding FasterSpeeding added the enhancement New feature or request label Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #147 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   79.48%   79.53%   +0.04%     
==========================================
  Files          80       80              
  Lines       10096    10128      +32     
  Branches     1286     1288       +2     
==========================================
+ Hits         8025     8055      +30     
- Misses       2001     2003       +2     
  Partials       70       70              
Impacted Files Coverage Δ
hikari/api/entity_factory.py 100.00% <ø> (ø)
hikari/api/rest.py 100.00% <ø> (ø)
hikari/channels.py 100.00% <100.00%> (ø)
hikari/guilds.py 95.12% <100.00%> (+0.01%) ⬆️
hikari/impl/entity_factory.py 100.00% <100.00%> (ø)
hikari/impl/rest.py 89.09% <100.00%> (+0.11%) ⬆️
hikari/utilities/routes.py 100.00% <100.00%> (ø)
hikari/impl/bot.py 32.73% <0.00%> (-0.24%) ⬇️
hikari/impl/shard.py 78.60% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7507307...2698fa1. Read the comment docs.

davfsa
davfsa previously approved these changes Sep 9, 2020
Copy link
Member

@davfsa davfsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@FasterSpeeding
Copy link
Collaborator Author

FasterSpeeding commented Sep 9, 2020

Gonna add some methods to the Follow object real quick before merging

hikari/channels.py Outdated Show resolved Hide resolved
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, but I have a few questions and suggestions at the cost of being nitpicky :)

hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/rest.py Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/api/rest.py Outdated Show resolved Hide resolved
hikari/channels.py Outdated Show resolved Hide resolved
hikari/impl/rest.py Outdated Show resolved Hide resolved
hikari/impl/rest.py Show resolved Hide resolved
hikari/utilities/routes.py Show resolved Hide resolved
tests/hikari/impl/test_rest.py Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Sep 9, 2020

ping me when updated and ill look again.

FasterSpeeding added a commit to FasterSpeeding/hikari that referenced this pull request Sep 9, 2020
@FasterSpeeding FasterSpeeding requested a review from a user September 9, 2020 20:41
@ghost ghost requested review from davfsa and removed request for a user September 9, 2020 22:16
@ghost ghost assigned FasterSpeeding Sep 9, 2020
@ghost ghost added this to the 2.0.0 milestone Sep 9, 2020
@ghost ghost merged commit 44a5144 into hikari-py:master Sep 10, 2020
@FasterSpeeding FasterSpeeding deleted the task/135-crossposts branch September 16, 2020 09:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants